Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Included ALE plot tests. #816

Merged

Conversation

RobertSamoilescu
Copy link
Collaborator

This PR includes the tests for the ALE plotting functionality. It also increases coverage to addresses #760.

Copy link
Contributor

@jklaise jklaise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks! (CI pending)

@codecov
Copy link

codecov bot commented Nov 8, 2022

Codecov Report

Merging #816 (94b061e) into master (2c22f59) will increase coverage by 0.88%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #816      +/-   ##
==========================================
+ Coverage   75.48%   76.37%   +0.88%     
==========================================
  Files          73       73              
  Lines        8477     8477              
==========================================
+ Hits         6399     6474      +75     
+ Misses       2078     2003      -75     
Flag Coverage Δ
macos-latest-3.10 76.24% <ø> (+0.88%) ⬆️
ubuntu-latest-3.10 76.24% <ø> (+0.79%) ⬆️
ubuntu-latest-3.7 76.19% <ø> (+0.89%) ⬆️
ubuntu-latest-3.8 76.23% <ø> (+0.88%) ⬆️
ubuntu-latest-3.9 76.23% <ø> (+0.88%) ⬆️
windows-latest-3.9 73.80% <ø> (+0.79%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
alibi/explainers/ale.py 98.26% <0.00%> (+32.60%) ⬆️

@RobertSamoilescu RobertSamoilescu merged commit 1ba9ead into SeldonIO:master Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants